flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...
Date Tue, 01 Dec 2015 14:38:45 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r46285044
  
    --- Diff: flink-clients/src/test/java/org/apache/flink/client/CliFrontendStopTest.java
---
    @@ -0,0 +1,157 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.client;
    +
    +import java.util.UUID;
    +
    +import akka.actor.*;
    +import akka.testkit.JavaTestKit;
    +
    +import org.apache.flink.client.cli.CommandLineOptions;
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.runtime.instance.ActorGateway;
    +import org.apache.flink.runtime.instance.AkkaActorGateway;
    +import org.apache.flink.runtime.messages.JobManagerMessages;
    +import org.junit.AfterClass;
    +import org.junit.BeforeClass;
    +import org.junit.Test;
    +
    +import scala.Option;
    +import static org.apache.flink.client.CliFrontendTestUtils.pipeSystemOutToNull;
    +import static org.junit.Assert.*;
    +
    +public class CliFrontendStopTest {
    +
    +	private static ActorSystem actorSystem;
    +
    +	@BeforeClass
    +	public static void setup() {
    +		pipeSystemOutToNull();
    +		actorSystem = ActorSystem.create("TestingActorSystem");
    +	}
    +
    +	@AfterClass
    +	public static void teardown() {
    +		JavaTestKit.shutdownActorSystem(actorSystem);
    +		actorSystem = null;
    +	}
    +
    +	@BeforeClass
    +	public static void init() {
    --- End diff --
    
    For me it doesn't make sense to have multiple `@BeforeClass` methods. IMO, you should
change it here and address `CliFrontendCancelTest` as part of another PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message