flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjsax <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...
Date Tue, 01 Dec 2015 14:31:04 GMT
Github user mjsax commented on a diff in the pull request:

    --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
    @@ -89,13 +99,9 @@ public BoltWrapper(final IRichBolt bolt) throws IllegalArgumentException
     	 * used within a Flink streaming program. The given input schema enable attribute-by-name
access for input types
     	 * {@link Tuple0} to {@link Tuple25}. The output type will be one of {@link Tuple0}
to {@link Tuple25} depending on
     	 * the bolt's declared number of attributes.
    -	 * 
    -	 * @param bolt
    -	 *            The Storm {@link IRichBolt bolt} to be used.
    +	 * @param bolt The Storm {@link IRichBolt bolt} to be used.
     	 * @param inputSchema
    -	 *            The schema (ie, ordered field names) of the input stream.
    -	 * @throws IllegalArgumentException
    --- End diff --
    Please keep `@throws`

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message