Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 80FA218B8B for ; Tue, 17 Nov 2015 17:59:11 +0000 (UTC) Received: (qmail 74311 invoked by uid 500); 17 Nov 2015 17:59:11 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 74271 invoked by uid 500); 17 Nov 2015 17:59:11 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 74136 invoked by uid 99); 17 Nov 2015 17:59:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Nov 2015 17:59:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0D4712C1F6A for ; Tue, 17 Nov 2015 17:59:11 +0000 (UTC) Date: Tue, 17 Nov 2015 17:59:11 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-2978) Integrate web submission interface into the new dashboard MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009142#comment-15009142 ] ASF GitHub Bot commented on FLINK-2978: --------------------------------------- Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1338#discussion_r45094375 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarListHandler.java --- @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.webmonitor.handlers; + +import com.fasterxml.jackson.core.JsonGenerator; +import org.apache.flink.client.program.PackagedProgram; +import org.apache.flink.client.program.ProgramInvocationException; +import org.apache.flink.runtime.instance.ActorGateway; +import org.apache.flink.runtime.webmonitor.RuntimeMonitorHandler; + +import java.io.File; +import java.io.FilenameFilter; +import java.io.IOException; +import java.io.StringWriter; +import java.util.Map; +import java.util.UUID; +import java.util.jar.JarFile; +import java.util.jar.Manifest; + +public class JarListHandler implements RequestHandler, RequestHandler.JsonResponse { + + private final File jarDir; + + public JarListHandler(File jarDirectory) { + jarDir = jarDirectory; + } + + @Override + public String handleRequest(Map params, ActorGateway jobManager) throws Exception { + try { + StringWriter writer = new StringWriter(); + JsonGenerator gen = JsonFactory.jacksonFactory.createJsonGenerator(writer); + gen.writeStartObject(); + gen.writeStringField("address", params.get(RuntimeMonitorHandler.WEB_MONITOR_ADDRESS_KEY)); + if (jarDir != null) { --- End diff -- Sorry, You are right, there was no need to justify myself ;) > Integrate web submission interface into the new dashboard > --------------------------------------------------------- > > Key: FLINK-2978 > URL: https://issues.apache.org/jira/browse/FLINK-2978 > Project: Flink > Issue Type: New Feature > Components: Web Client, Webfrontend > Reporter: Sachin Goel > Assignee: Sachin Goel > > As discussed in http://mail-archives.apache.org/mod_mbox/flink-dev/201511.mbox/%3CCAL3J2zQg6UBKNDnm=8TshPZ6r4p2Jvx7NRLOm7cAAJrb9S6PYA@mail.gmail.com%3E, we should integrate job submission from the web into the dashboard. -- This message was sent by Atlassian JIRA (v6.3.4#6332)