Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4A60D18084 for ; Sat, 21 Nov 2015 12:31:11 +0000 (UTC) Received: (qmail 88411 invoked by uid 500); 21 Nov 2015 12:31:11 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 88351 invoked by uid 500); 21 Nov 2015 12:31:11 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 88327 invoked by uid 99); 21 Nov 2015 12:31:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 Nov 2015 12:31:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0B3012C0453 for ; Sat, 21 Nov 2015 12:31:11 +0000 (UTC) Date: Sat, 21 Nov 2015 12:31:10 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-2956) Migrate integration tests for Table API MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020428#comment-15020428 ] ASF GitHub Bot commented on FLINK-2956: --------------------------------------- Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1349#discussion_r45545495 --- Diff: flink-staging/flink-table/src/test/java/org/apache/flink/api/java/table/test/CastingITCase.java --- @@ -44,29 +41,13 @@ public CastingITCase(TestExecutionMode mode){ super(mode); } - private String resultPath; - private String expected = ""; - - @Rule - public TemporaryFolder tempFolder = new TemporaryFolder(); - - @Before - public void before() throws Exception{ - resultPath = tempFolder.newFile().toURI().toString(); - } - - @After - public void after() throws Exception{ - compareResultsByLinesInMemory(expected, resultPath); - } - @Test public void testAutoCastToString() throws Exception { ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment(); TableEnvironment tableEnv = new TableEnvironment(); DataSource> input = - env.fromElements(new Tuple7( + env.fromElements(new Tuple7<>( (byte) 1, (short) 1, 1, 1L, 1.0f, 1.0d, "Hello")); --- End diff -- I think merging L51 and L50 would be better. After omitting generic parameters, we don't need a newline for this. > Migrate integration tests for Table API > --------------------------------------- > > Key: FLINK-2956 > URL: https://issues.apache.org/jira/browse/FLINK-2956 > Project: Flink > Issue Type: Sub-task > Components: Tests > Reporter: Chengxiang Li > Priority: Minor > > Migrate integration tests of Table API from temp file to collect() as described in umbrella jira.. -- This message was sent by Atlassian JIRA (v6.3.4#6332)