Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 76FAF181F9 for ; Sat, 14 Nov 2015 00:45:11 +0000 (UTC) Received: (qmail 8596 invoked by uid 500); 14 Nov 2015 00:45:11 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 8536 invoked by uid 500); 14 Nov 2015 00:45:11 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 8492 invoked by uid 99); 14 Nov 2015 00:45:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Nov 2015 00:45:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 31B0D2C1F76 for ; Sat, 14 Nov 2015 00:45:11 +0000 (UTC) Date: Sat, 14 Nov 2015 00:45:11 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-2913) Close of ObjectOutputStream should be enclosed in finally block in FsStateBackend MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-2913?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1500= 4981#comment-15004981 ]=20 ASF GitHub Bot commented on FLINK-2913: --------------------------------------- GitHub user tedyu opened a pull request: https://github.com/apache/flink/pull/1353 [FLINK-2913] Close of ObjectOutputStream should be enclosed in finall= =E2=80=A6 =E2=80=A6y block in FsStateBackend You can merge this pull request into a Git repository by running: $ git pull https://github.com/tedyu/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1353.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1353 =20 ---- commit a00949b761efb0ceb6efb23a57095812c7ed2778 Author: tedyu Date: 2015-11-14T00:43:53Z [FLINK-2913] Close of ObjectOutputStream should be enclosed in finally = block in FsStateBackend ---- > Close of ObjectOutputStream should be enclosed in finally block in FsStat= eBackend > -------------------------------------------------------------------------= -------- > > Key: FLINK-2913 > URL: https://issues.apache.org/jira/browse/FLINK-2913 > Project: Flink > Issue Type: Bug > Reporter: Ted Yu > Priority: Minor > > {code} > ObjectOutputStream os =3D new ObjectOutputStream(outStream); > os.writeObject(state); > os.close(); > {code} > If IOException is thrown out of writeObject(), the close() call would be = skipped. -- This message was sent by Atlassian JIRA (v6.3.4#6332)