Return-Path: 
 <issues-return-37173-apmail-flink-issues-archive=flink.apache.org@flink.apache.org>
X-Original-To: apmail-flink-issues-archive@minotaur.apache.org
Delivered-To: apmail-flink-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 4873F18662
	for <apmail-flink-issues-archive@minotaur.apache.org>;
 Sun, 22 Nov 2015 14:15:11 +0000 (UTC)
Received: (qmail 36539 invoked by uid 500); 22 Nov 2015 14:15:11 -0000
Delivered-To: apmail-flink-issues-archive@flink.apache.org
Received: (qmail 36496 invoked by uid 500); 22 Nov 2015 14:15:11 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 36466 invoked by uid 99); 22 Nov 2015 14:15:11 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Nov 2015 14:15:11 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 029DC2C044E
	for <issues@flink.apache.org>; Sun, 22 Nov 2015 14:15:10 +0000 (UTC)
Date: Sun, 22 Nov 2015 14:15:10 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12905523.1445001440000.151265.1448201710947@Atlassian.JIRA>
In-Reply-To: <JIRA.12905523.1445001440000@Atlassian.JIRA>
References: <JIRA.12905523.1445001440000@Atlassian.JIRA>
 <JIRA.12905523.1445001440542@arcas>
Subject: [jira] [Commented] (FLINK-2861) Fields grouping on split streams
 fails
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/FLINK-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021013#comment-15021013 ] 

ASF GitHub Bot commented on FLINK-2861:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1387#discussion_r45559371
  
    --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java ---
    @@ -209,12 +209,8 @@ public void open() throws Exception {
     		super.open();
     
     		this.flinkCollector = new TimestampedCollector<OUT>(output);
    -		OutputCollector stormCollector = null;
    -
    -		if (this.numberOfAttributes.size() > 0) {
    -			stormCollector = new OutputCollector(new BoltCollector<OUT>(
    -					this.numberOfAttributes, flinkCollector));
    -		}
    +		final OutputCollector stormCollector = new OutputCollector(new BoltCollector<OUT>(
    +				this.numberOfAttributes, flinkCollector));
    --- End diff --
    
    Yes, I fixed that in my code base as well...


> Fields grouping on split streams fails
> --------------------------------------
>
>                 Key: FLINK-2861
>                 URL: https://issues.apache.org/jira/browse/FLINK-2861
>             Project: Flink
>          Issue Type: Bug
>          Components: Storm Compatibility
>    Affects Versions: 0.10.0
>            Reporter: Stephan Ewen
>            Assignee: Matthias J. Sax
>
> Using split streams works for shuffle grouping, but not for Fields grouping.
> The reason is that the KeySelector expects an array, and the given type is the {{SplitStreamType}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)