Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 073ED189D2 for ; Wed, 18 Nov 2015 09:49:12 +0000 (UTC) Received: (qmail 34545 invoked by uid 500); 18 Nov 2015 09:49:11 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 34345 invoked by uid 500); 18 Nov 2015 09:49:11 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 34178 invoked by uid 99); 18 Nov 2015 09:49:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Nov 2015 09:49:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 493042C1F74 for ; Wed, 18 Nov 2015 09:49:11 +0000 (UTC) Date: Wed, 18 Nov 2015 09:49:11 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-2017) Add predefined required parameters to ParameterTool MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010647#comment-15010647 ] ASF GitHub Bot commented on FLINK-2017: --------------------------------------- Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1097#issuecomment-157660361 Thank you for reacting so quickly to my feedback. I'm sorry for the delays during the PR review. > Add predefined required parameters to ParameterTool > --------------------------------------------------- > > Key: FLINK-2017 > URL: https://issues.apache.org/jira/browse/FLINK-2017 > Project: Flink > Issue Type: Improvement > Affects Versions: 0.9 > Reporter: Robert Metzger > Labels: starter > > In FLINK-1525 we've added the {{ParameterTool}}. > During the PR review, there was a request for required parameters. > This issue is about implementing a facility to define required parameters. The tool should also be able to print a help menu with a list of all parameters. > This test case shows my initial ideas how to design the API > {code} > @Test > public void requiredParameters() { > RequiredParameters required = new RequiredParameters(); > Option input = required.add("input").alt("i").help("Path to input file or directory"); // parameter with long and short variant > required.add("output"); // parameter only with long variant > Option parallelism = required.add("parallelism").alt("p").type(Integer.class); // parameter with type > Option spOption = required.add("sourceParallelism").alt("sp").defaultValue(12).help("Number specifying the number of parallel data source instances"); // parameter with default value, specifying the type. > Option executionType = required.add("executionType").alt("et").defaultValue("pipelined").choices("pipelined", "batch"); > ParameterUtil parameter = ParameterUtil.fromArgs(new String[]{"-i", "someinput", "--output", "someout", "-p", "15"}); > required.check(parameter); > required.printHelp(); > required.checkAndPopulate(parameter); > String inputString = input.get(); > int par = parallelism.getInteger(); > String output = parameter.get("output"); > int sourcePar = parameter.getInteger(spOption.getName()); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)