Return-Path: 
 <issues-return-35305-apmail-flink-issues-archive=flink.apache.org@flink.apache.org>
X-Original-To: apmail-flink-issues-archive@minotaur.apache.org
Delivered-To: apmail-flink-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id B5BFA17619
	for <apmail-flink-issues-archive@minotaur.apache.org>;
 Thu,  5 Nov 2015 08:42:11 +0000 (UTC)
Received: (qmail 94111 invoked by uid 500); 5 Nov 2015 08:41:36 -0000
Delivered-To: apmail-flink-issues-archive@flink.apache.org
Received: (qmail 94079 invoked by uid 500); 5 Nov 2015 08:41:36 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 94061 invoked by uid 99); 5 Nov 2015 08:41:36 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Nov 2015 08:41:36 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id ED4E22C1F63
	for <issues@flink.apache.org>; Thu,  5 Nov 2015 08:41:27 +0000 (UTC)
Date: Thu, 5 Nov 2015 08:41:27 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12719153.1402305258000.160794.1446712887968@Atlassian.JIRA>
In-Reply-To: <JIRA.12719153.1402305258000@Atlassian.JIRA>
References: <JIRA.12719153.1402305258000@Atlassian.JIRA>
 <JIRA.12719153.1402305258826@arcas>
Subject: [jira] [Commented] (FLINK-7) [GitHub] Enable Range Partitioner
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991335#comment-14991335 ] 

ASF GitHub Bot commented on FLINK-7:
------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1255#discussion_r43987736
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/shipping/OutputEmitter.java ---
    @@ -135,7 +116,7 @@ public OutputEmitter(ShipStrategyType strategy, TypeComparator<T> comparator, Pa
     		case PARTITION_CUSTOM:
     			return customPartition(record.getInstance(), numberOfChannels);
     		case PARTITION_RANGE:
    -			return rangePartition(record.getInstance(), numberOfChannels);
    +			return rangePartition((Tuple2<Integer, ?>)record.getInstance(), numberOfChannels);
    --- End diff --
    
    Yes, the current version of `DataDistribution` was supported by a previous version of the API (even pre-Flink). With the generalized data model, `DataDistribution` should be backed by a `Object[][]` instead of `Key<?>[]` and the `TypeComparator`s should be used to compare the individual key fields.
    
    I think if we change DataDistribution now to operate on `Object[][]`, the follow up task would become much easier. Also if you plan to add a `DataDistribution` later, wouldn't it make more sense to update it now, instead of removing it first and adding an updated version later again?


> [GitHub] Enable Range Partitioner
> ---------------------------------
>
>                 Key: FLINK-7
>                 URL: https://issues.apache.org/jira/browse/FLINK-7
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Runtime
>            Reporter: GitHub Import
>            Assignee: Chengxiang Li
>             Fix For: pre-apache
>
>
> The range partitioner is currently disabled. We need to implement the following aspects:
> 1) Distribution information, if available, must be propagated back together with the ordering property.
> 2) A generic bucket lookup structure (currently specific to PactRecord).
> Tests to re-enable after fixing this issue:
>  - TeraSortITCase
>  - GlobalSortingITCase
>  - GlobalSortingMixedOrderITCase
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/7
> Created by: [StephanEwen|https://github.com/StephanEwen]
> Labels: core, enhancement, optimizer, 
> Milestone: Release 0.4
> Assignee: [fhueske|https://github.com/fhueske]
> Created at: Fri Apr 26 13:48:24 CEST 2013
> State: open



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)