Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: mxm <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-1398-flink@git.apache.org>
In-Reply-To: <git-pr-1398-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-2837][storm] various improvements
 for S...
Content-Type: text/plain
Message-Id: <20151126103218.5F04FE2C1C@git1-us-west.apache.org>
Date: Thu, 26 Nov 2015 10:32:18 +0000 (UTC)

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1398#discussion_r45963933
  
    --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java ---
    @@ -44,16 +45,30 @@
     	/** The schema (ie, ordered field names) of the tuple */
     	private final Fields schema;
     
    +	private final int taskId;
    +	private final String producerStreamId;
    +	private final MessageId id;
    +	private final String producerComponentId;
    +
    +
    +	/**
    +	 * Constructor which sets defaults for producerComponentId, taskId, and componentID
    +	 * @param flinkTuple the Flink tuple
    +	 * @param schema The schema of the storm fields
    +	 */
    +	StormTuple(final IN flinkTuple, final Fields schema) {
    +		this(flinkTuple, schema, -1, "testStream", "componentID");
    +	}
    --- End diff --
    
    The use of null is often problematic. I prefer default values.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---