Return-Path: 
 <issues-return-37564-apmail-flink-issues-archive=flink.apache.org@flink.apache.org>
X-Original-To: apmail-flink-issues-archive@minotaur.apache.org
Delivered-To: apmail-flink-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 411D81853B
	for <apmail-flink-issues-archive@minotaur.apache.org>;
 Tue, 24 Nov 2015 12:14:31 +0000 (UTC)
Received: (qmail 16728 invoked by uid 500); 24 Nov 2015 12:14:31 -0000
Delivered-To: apmail-flink-issues-archive@flink.apache.org
Received: (qmail 16680 invoked by uid 500); 24 Nov 2015 12:14:31 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 16671 invoked by uid 99); 24 Nov 2015 12:14:31 -0000
Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Nov 2015 12:14:31 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org)
 with ESMTP id B6776180992
	for <issues@flink.apache.org>; Tue, 24 Nov 2015 12:14:30 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.427
X-Spam-Level: 
X-Spam-Status: No, score=0.427 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01,
	RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.554, URIBL_BLOCKED=0.001]
	autolearn=disabled
Received: from mx1-us-west.apache.org ([10.40.0.8])
	by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new,
 port 10024)
	with ESMTP id 0g6JsuD1kYUi for <issues@flink.apache.org>;
	Tue, 24 Nov 2015 12:14:22 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with
 SMTP id 1DE2922F0A
	for <issues@flink.incubator.apache.org>;
 Tue, 24 Nov 2015 12:14:22 +0000 (UTC)
Received: (qmail 16627 invoked by uid 99); 24 Nov 2015 12:14:21 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Nov 2015 12:14:21 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id D434EDFFF9; Tue, 24 Nov 2015 12:14:21 +0000 (UTC)
From: mjsax <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-1398-flink@git.apache.org>
In-Reply-To: <git-pr-1398-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-2837][storm] various improvements
 for S...
Content-Type: text/plain
Message-Id: <20151124121421.D434EDFFF9@git1-us-west.apache.org>
Date: Tue, 24 Nov 2015 12:14:21 +0000 (UTC)

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1398#discussion_r45727399
  
    --- Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/StormTupleTest.java ---
    @@ -595,7 +593,7 @@ public void testGetBinaryByFieldPojoGetter() throws Exception {
     	private <T> StormTuple testGetByField(int arity, int index, T value)
     			throws Exception {
     
    -		assert (index < arity);
    +		Assert.assertTrue(index < arity);
     
    --- End diff --
    
    This is not a assertion for a test result; thus usage of `assert` is correct (checks if test is written properly).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---