flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3088] [serialization] Fix copy method o...
Date Fri, 27 Nov 2015 14:19:03 GMT
GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/1415

    [FLINK-3088] [serialization] Fix copy method of TypeSerializers which use Kryo

    Some TypeSerializer, WritableSerializer, ValueSerializer, and AvroSerializer, and
    comparators, WritableComparator and ValueComparator, use Kryo to copy records.
    In case where the Kryo serializer cannot copy the record, the copy method fails.
    This is however not necessary, because one can copy the element by serializing
    the record to a byte array and deserializing it from this array. This PR adds
    this behaviour to the respective classes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixWritableSerializer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1415.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1415
    
----
commit e00efd5b00ed4d0af85313baeae3c676457253cb
Author: Till Rohrmann <trohrmann@apache.org>
Date:   2015-11-27T14:14:15Z

    [FLINK-3088] [serialization] Fix copy method of TypeSerializer which use Kryo
    
    Some TypeSerializer, WritableSerializer, ValueSerializer, and AvroSerializer, and
    comparators, WritableComparator and ValueComparator, use Kryo to copy records.
    In case where the Kryo serializer cannot copy the record, the copy method fails.
    This is however not necessary, because one can copy the element by serializing
    the record to a byte array and deserializing it from this array. This PR adds
    this behaviour to the respective classes.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message