flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2978) Integrate web submission interface into the new dashboard
Date Tue, 17 Nov 2015 18:51:11 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009240#comment-15009240
] 

ASF GitHub Bot commented on FLINK-2978:
---------------------------------------

Github user sachingoel0101 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1338#discussion_r45101828
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandler.java
---
    @@ -113,7 +117,17 @@ private void respondAsLeader(ChannelHandlerContext ctx, Routed routed,
ActorGate
     		DefaultFullHttpResponse response;
     
     		try {
    -			String result = handler.handleRequest(routed.pathParams(), jobManager);
    +			Map<String, String> params = routed.pathParams();
    --- End diff --
    
    I was not aware of this particular aspect of REST. How should query params be represented?
Since here, the resource is `/jars/:jarid`, and representing a plan or submit as `/jars/:jarid/:parallelism/:entry-class/...`
doesn't seem okay.


> Integrate web submission interface into the new dashboard
> ---------------------------------------------------------
>
>                 Key: FLINK-2978
>                 URL: https://issues.apache.org/jira/browse/FLINK-2978
>             Project: Flink
>          Issue Type: New Feature
>          Components: Web Client, Webfrontend
>            Reporter: Sachin Goel
>            Assignee: Sachin Goel
>
> As discussed in http://mail-archives.apache.org/mod_mbox/flink-dev/201511.mbox/%3CCAL3J2zQg6UBKNDnm=8TshPZ6r4p2Jvx7NRLOm7cAAJrb9S6PYA@mail.gmail.com%3E,
we should integrate job submission from the web into the dashboard.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message