flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2961) Add support for basic type Date in Table API
Date Tue, 03 Nov 2015 15:01:27 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987416#comment-14987416

ASF GitHub Bot commented on FLINK-2961:

Github user aljoscha commented on a diff in the pull request:

    --- Diff: flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/codegen/ExpressionCodeGenerator.scala
    @@ -202,6 +210,23 @@ abstract class ExpressionCodeGenerator[R](
    +      case expressions.Literal(dateValue: Date, DATE_TYPE_INFO) =>
    +        val dateName = s"""date_${dateValue.getTime}"""
    +        val dateStmt = s"""static java.util.Date $dateName
    +             |= new java.util.Date(${dateValue.getTime});""".stripMargin
    +        reusableStatements.add(dateStmt)
    +        if (nullCheck) {
    +          s"""
    +            |val $nullTerm = false
    --- End diff --
    These are not tested anywhere. We should maybe add tests that also verify the Code Generator
when `nullCheck` is `true`.

> Add support for basic type Date in Table API
> --------------------------------------------
>                 Key: FLINK-2961
>                 URL: https://issues.apache.org/jira/browse/FLINK-2961
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Minor
> Currently, the basic type {{Date}} is not implemented in the Table API. In order to have
a mapping of the most important ANSI SQL types for FLINK-2099. It makes sense to add support
for {{Date}} to represent date, time and timestamps of milliseconds precision.
> Only the types `LONG` and `STRING` can be casted to `DATE` and vice versa. A `LONG` casted
to `DATE` must be a milliseconds timestamp. A `STRING` casted to `DATE` must have the format
"`yyyy-MM-dd HH:mm:ss.SSS`", "`yyyy-MM-dd`", "`HH:mm:ss`", or a milliseconds timestamp. All
timestamps refer to the UTC timezone beginning from January 1, 1970, 00:00:00 in milliseconds.

This message was sent by Atlassian JIRA

View raw message