flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2956) Migrate integration tests for Table API
Date Sat, 21 Nov 2015 12:31:10 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020428#comment-15020428
] 

ASF GitHub Bot commented on FLINK-2956:
---------------------------------------

Github user chiwanpark commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1349#discussion_r45545495
  
    --- Diff: flink-staging/flink-table/src/test/java/org/apache/flink/api/java/table/test/CastingITCase.java
---
    @@ -44,29 +41,13 @@ public CastingITCase(TestExecutionMode mode){
     		super(mode);
     	}
     
    -	private String resultPath;
    -	private String expected = "";
    -
    -	@Rule
    -	public TemporaryFolder tempFolder = new TemporaryFolder();
    -
    -	@Before
    -	public void before() throws Exception{
    -		resultPath = tempFolder.newFile().toURI().toString();
    -	}
    -
    -	@After
    -	public void after() throws Exception{
    -		compareResultsByLinesInMemory(expected, resultPath);
    -	}
    -
     	@Test
     	public void testAutoCastToString() throws Exception {
     		ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment();
     		TableEnvironment tableEnv = new TableEnvironment();
     
     		DataSource<Tuple7<Byte, Short, Integer, Long, Float, Double, String>> input
=
    -				env.fromElements(new Tuple7<Byte, Short, Integer, Long, Float, Double, String>(
    +				env.fromElements(new Tuple7<>(
     						(byte) 1, (short) 1, 1, 1L, 1.0f, 1.0d, "Hello"));
    --- End diff --
    
    I think merging L51 and L50 would be better. After omitting generic parameters, we don't
need a newline for this.


> Migrate integration tests for Table API
> ---------------------------------------
>
>                 Key: FLINK-2956
>                 URL: https://issues.apache.org/jira/browse/FLINK-2956
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Chengxiang Li
>            Priority: Minor
>
> Migrate integration tests of Table API from temp file to collect() as described in umbrella
jira..



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message