flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2956) Migrate integration tests for Table API
Date Sat, 21 Nov 2015 12:29:10 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020426#comment-15020426
] 

ASF GitHub Bot commented on FLINK-2956:
---------------------------------------

Github user chiwanpark commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1349#discussion_r45545486
  
    --- Diff: flink-staging/flink-table/src/test/java/org/apache/flink/api/java/table/test/AsITCase.java
---
    @@ -68,16 +49,14 @@ public void testAs() throws Exception {
     				tableEnv.fromDataSet(CollectionDataSets.get3TupleDataSet(env), "a, b, c");
     
     		DataSet<Row> ds = tableEnv.toDataSet(table, Row.class);
    -		ds.writeAsText(resultPath, FileSystem.WriteMode.OVERWRITE);
    -
    -		env.execute();
    -
    -		expected = "1,1,Hi\n" + "2,2,Hello\n" + "3,2,Hello world\n" + "4,3,Hello world, " +
    +		List<Row> results =ds.collect();
    --- End diff --
    
    Please add a space after `=`.


> Migrate integration tests for Table API
> ---------------------------------------
>
>                 Key: FLINK-2956
>                 URL: https://issues.apache.org/jira/browse/FLINK-2956
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Chengxiang Li
>            Priority: Minor
>
> Migrate integration tests of Table API from temp file to collect() as described in umbrella
jira..



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message