flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2861) Fields grouping on split streams fails
Date Sun, 22 Nov 2015 14:15:10 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021013#comment-15021013
] 

ASF GitHub Bot commented on FLINK-2861:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1387#discussion_r45559371
  
    --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
    @@ -209,12 +209,8 @@ public void open() throws Exception {
     		super.open();
     
     		this.flinkCollector = new TimestampedCollector<OUT>(output);
    -		OutputCollector stormCollector = null;
    -
    -		if (this.numberOfAttributes.size() > 0) {
    -			stormCollector = new OutputCollector(new BoltCollector<OUT>(
    -					this.numberOfAttributes, flinkCollector));
    -		}
    +		final OutputCollector stormCollector = new OutputCollector(new BoltCollector<OUT>(
    +				this.numberOfAttributes, flinkCollector));
    --- End diff --
    
    Yes, I fixed that in my code base as well...


> Fields grouping on split streams fails
> --------------------------------------
>
>                 Key: FLINK-2861
>                 URL: https://issues.apache.org/jira/browse/FLINK-2861
>             Project: Flink
>          Issue Type: Bug
>          Components: Storm Compatibility
>    Affects Versions: 0.10.0
>            Reporter: Stephan Ewen
>            Assignee: Matthias J. Sax
>
> Using split streams works for shuffle grouping, but not for Fields grouping.
> The reason is that the KeySelector expects an array, and the given type is the {{SplitStreamType}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message