flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2249) ExecutionEnvironment: Ignore calls to execute() if no data sinks defined
Date Wed, 18 Nov 2015 13:51:11 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011005#comment-15011005
] 

ASF GitHub Bot commented on FLINK-2249:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1375#issuecomment-157718710
  
    I think there was a discussion about that before, and the decision was to not change the
behavior. The reason was that failing loudly with a good error message is easier to figure
out than silently ignoring a call to execute().


> ExecutionEnvironment: Ignore calls to execute() if no data sinks defined
> ------------------------------------------------------------------------
>
>                 Key: FLINK-2249
>                 URL: https://issues.apache.org/jira/browse/FLINK-2249
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API, Scala API
>    Affects Versions: 0.9
>            Reporter: Maximilian Michels
>            Assignee: Chesnay Schepler
>
> The basic skeleton of a Flink program looks like this: 
> {code}
> ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment();
> // bootstrap DataSet
> DataSet<..> ds = env.fromElements(1,2,3,4);
> // perform transformations
> ..
> // define sinks, e.g.
> ds.writeToTextFile("/some/path");
> // execute
> env.execute()
> {code}
> First thing users do is to change {{ds.writeToTextFile("/some/path");}} into {{ds.print();}}.
But that fails with an Exception ("No new data sinks defined...").
> In FLINK-2026 we made this exception message easier to understand. However, users still
don't understand what is happening. Especially because they see Flink executing and then failing.
> I propose to ignore calls to execute() when no sinks are defined. Instead, we should
just print a warning: "Detected call to execute without any data sinks. Not executing."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message