flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7) [GitHub] Enable Range Partitioner
Date Thu, 05 Nov 2015 08:41:27 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991335#comment-14991335

ASF GitHub Bot commented on FLINK-7:

Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/shipping/OutputEmitter.java
    @@ -135,7 +116,7 @@ public OutputEmitter(ShipStrategyType strategy, TypeComparator<T>
comparator, Pa
     			return customPartition(record.getInstance(), numberOfChannels);
     		case PARTITION_RANGE:
    -			return rangePartition(record.getInstance(), numberOfChannels);
    +			return rangePartition((Tuple2<Integer, ?>)record.getInstance(), numberOfChannels);
    --- End diff --
    Yes, the current version of `DataDistribution` was supported by a previous version of
the API (even pre-Flink). With the generalized data model, `DataDistribution` should be backed
by a `Object[][]` instead of `Key<?>[]` and the `TypeComparator`s should be used to
compare the individual key fields.
    I think if we change DataDistribution now to operate on `Object[][]`, the follow up task
would become much easier. Also if you plan to add a `DataDistribution` later, wouldn't it
make more sense to update it now, instead of removing it first and adding an updated version
later again?

> [GitHub] Enable Range Partitioner
> ---------------------------------
>                 Key: FLINK-7
>                 URL: https://issues.apache.org/jira/browse/FLINK-7
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Runtime
>            Reporter: GitHub Import
>            Assignee: Chengxiang Li
>             Fix For: pre-apache
> The range partitioner is currently disabled. We need to implement the following aspects:
> 1) Distribution information, if available, must be propagated back together with the
ordering property.
> 2) A generic bucket lookup structure (currently specific to PactRecord).
> Tests to re-enable after fixing this issue:
>  - TeraSortITCase
>  - GlobalSortingITCase
>  - GlobalSortingMixedOrderITCase
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/7
> Created by: [StephanEwen|https://github.com/StephanEwen]
> Labels: core, enhancement, optimizer, 
> Milestone: Release 0.4
> Assignee: [fhueske|https://github.com/fhueske]
> Created at: Fri Apr 26 13:48:24 CEST 2013
> State: open

This message was sent by Atlassian JIRA

View raw message