flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjsax <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...
Date Thu, 26 Nov 2015 10:49:15 GMT
Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1398#discussion_r45965523
  
    --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/FlinkTopologyContext.java
---
    @@ -27,13 +27,12 @@
     import backtype.storm.state.ISubscribedState;
     import backtype.storm.task.TopologyContext;
     import backtype.storm.tuple.Fields;
    +import clojure.lang.Atom;
     
    --- End diff --
    
    I see. DataArtians committer can do any change, but external committers get bullied if
they apply similar changes... It is not against you or the change itself -- it unifies the
style which does make sense. But I got bullied multiple times in other PRs when I did similar
stuff...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message