flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjsax <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...
Date Wed, 25 Nov 2015 16:45:47 GMT
Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1398#discussion_r45889838
  
    --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
    @@ -53,21 +51,26 @@
     	private static final long serialVersionUID = -4788589118464155835L;
     
     	/** The wrapped Storm {@link IRichBolt bolt}. */
    -	private final IRichBolt bolt;
    +	protected final IRichBolt bolt;
     	/** The name of the bolt. */
     	private final String name;
     	/** Number of attributes of the bolt's output tuples per stream. */
    -	private final HashMap<String, Integer> numberOfAttributes;
    +	protected final HashMap<String, Integer> numberOfAttributes;
     	/** The schema (ie, ordered field names) of the input stream. */
    -	private final Fields inputSchema;
    +	protected final Fields inputSchema;
     	/** The original Storm topology. */
     	protected StormTopology stormTopology;
     
    +	protected transient TopologyContext topologyContext;
    +
    +	protected final String inputComponentId;
    +	protected final String inputStreamId;
    +
    --- End diff --
    
    Please add JavaDoc to those three.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message