flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...
Date Tue, 24 Nov 2015 13:22:32 GMT
Github user mxm commented on a diff in the pull request:

    --- Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/StormTupleTest.java
    @@ -595,7 +593,7 @@ public void testGetBinaryByFieldPojoGetter() throws Exception {
     	private <T> StormTuple testGetByField(int arity, int index, T value)
     			throws Exception {
    -		assert (index < arity);
    +		Assert.assertTrue(index < arity);
    --- End diff --
    Because they are disabled during run time. This makes bugs e.g. in stack traces harder
to find.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message