flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjsax <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2837][storm] various improvements for S...
Date Tue, 24 Nov 2015 13:19:50 GMT
Github user mjsax commented on a diff in the pull request:

    --- Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
    @@ -180,8 +178,6 @@ public void testCreateTopologyContext() {
     		builder.setBolt("bolt2", (IRichBolt) operators.get("bolt2"), dops.get("bolt2")).allGrouping("spout2");
     		builder.setBolt("sink", (IRichBolt) operators.get("sink"), dops.get("sink"))
     				.shuffleGrouping("bolt1", TestDummyBolt.groupingStreamId)
    -				.shuffleGrouping("bolt1", TestDummyBolt.shuffleStreamId)
    -				.shuffleGrouping("bolt2", TestDummyBolt.groupingStreamId)
     				.shuffleGrouping("bolt2", TestDummyBolt.shuffleStreamId);
    --- End diff --
    We need to fix this... Supporting only 2 inputs is quite weak. Think about a union of
many input streams... Join is not the only use case for multiple inputs.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message