flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2901] Remove Record API dependencies fr...
Date Tue, 24 Nov 2015 10:29:47 GMT
Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1306#issuecomment-159223361
  
    Hi @zentol, sorry for the delayed review.
    You are right, `DeltaPageRankITCase` (which executes for some reason the Record API delta
iteration ConnectedComponents example) is identical to the DataSet `ConnectedComponentsITCase`.
So we do not port this one.
    I also agree to remove the checks for empty arguments in the `PreviewPlanDumpTest`. This
requires cooperation of the job, i.e., the job may not fail for empty arguments, and tests
exactly the same code paths as the tests with arguments, as far as I see.
    
    However, I do not think that the `ClassLoaderITCase` which calls the `KMeansForTest` is
a good replacement for the `IterativeKMeansITCase`. The programs are identical but, the `ClassLoaderITCase`
only checks if the program executes without an error and does not check the result.
    
    @zentol Is it OK for you if I add this one last test and merge this PR afterwards?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message