flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjsax <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...
Date Mon, 23 Nov 2015 17:51:56 GMT
Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r45635645
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
    @@ -188,9 +189,12 @@ public WebRuntimeMonitor(
     
     			// Cancel a job via GET (for proper integration with YARN this has to be performed
via GET)
     			.GET("/jobs/:jobid/yarn-cancel", handler(new JobCancellationHandler()))
    -			// DELETE is the preferred way of cancelling a job (Rest-conform)
    +			// DELETE is the preferred way of canceling a job (Rest-conform)
     			.DELETE("/jobs/:jobid", handler(new JobCancellationHandler()))
     
    +			// stop a job
    +			.DELETE("/jobs/:jobid/stop", handler(new JobStoppingHandler()))
    +
    --- End diff --
    
    Why is there actually `GET` and `DELETE` for `cancel`? Why not just `GET`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message