flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2861] Fields grouping on split streams ...
Date Sun, 22 Nov 2015 14:14:22 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1387#discussion_r45559371
  
    --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
    @@ -209,12 +209,8 @@ public void open() throws Exception {
     		super.open();
     
     		this.flinkCollector = new TimestampedCollector<OUT>(output);
    -		OutputCollector stormCollector = null;
    -
    -		if (this.numberOfAttributes.size() > 0) {
    -			stormCollector = new OutputCollector(new BoltCollector<OUT>(
    -					this.numberOfAttributes, flinkCollector));
    -		}
    +		final OutputCollector stormCollector = new OutputCollector(new BoltCollector<OUT>(
    +				this.numberOfAttributes, flinkCollector));
    --- End diff --
    
    Yes, I fixed that in my code base as well...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message