flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2978][web-dashboard][webclient] Integra...
Date Thu, 19 Nov 2015 16:10:56 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1338#discussion_r45360635
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
---
    @@ -635,8 +644,18 @@
     	 * The default number of archived jobs for the jobmanager
     	 */
     	public static final int DEFAULT_JOB_MANAGER_WEB_ARCHIVE_COUNT = 5;
    -	
    -	
    +
    +	/**
    +	 * By default, submitting jobs from the web-frontend is allowed.
    +	 */
    +	public static final boolean DEFAULT_JOB_MANAGER_WEB_SUBMISSION = true;
    +
    +	/**
    +	 * Default directory for uploaded file storage for the Web frontend.
    +	 */
    +	public static final String DEFAULT_JOB_MANAGER_WEB_UPLOAD_DIR =
    +			(System.getProperty("java.io.tmpdir") == null ? "/tmp" : System.getProperty("java.io.tmpdir"))
+ "/webmonitor/";
    --- End diff --
    
    I like your idea of putting the files into a `/jars/` in the webRootDir, so that the files
are deleted on shutdown!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message