flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3020][streaming] set number of task slo...
Date Thu, 19 Nov 2015 10:57:27 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1360#discussion_r45326391
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/LocalStreamEnvironment.java
---
    @@ -91,7 +91,11 @@ public JobExecutionResult execute(String jobName) throws Exception
{
     		configuration.addAll(jobGraph.getJobConfiguration());
     
     		configuration.setLong(ConfigConstants.TASK_MANAGER_MEMORY_SIZE_KEY, -1L);
    -		configuration.setInteger(ConfigConstants.TASK_MANAGER_NUM_TASK_SLOTS, getParallelism());
    +
    +		int parallelism = getParallelism() == defaultLocalParallelism ?
    +				defaultLocalParallelism : jobGraph.getMaximumParallelism();
    --- End diff --
    
    This currently means that in the default case, the slots do not respect the max parallel
operator, correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message