flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3002] Add Either type to the Java API
Date Wed, 18 Nov 2015 10:03:54 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1371#discussion_r45180384
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/EitherSerializer.java
---
    @@ -0,0 +1,194 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.java.typeutils.runtime;
    +
    +import java.io.IOException;
    +
    +import org.apache.flink.api.common.typeutils.TypeSerializer;
    +import org.apache.flink.api.java.typeutils.Either;
    +import org.apache.flink.core.memory.DataInputView;
    +import org.apache.flink.core.memory.DataOutputView;
    +
    +/**
    + * A {@link TypeSerializer} for the {@ link Either} type of the Java class.
    + *
    + * @param <L> the Left value type
    + * @param <R> the Right value type
    + */
    +public class EitherSerializer<L, R> extends TypeSerializer<Either<L, R>>
{
    +
    +	private static final long serialVersionUID = 1L;
    +
    +	private final Class<Either<L, R>> typeClass;
    +
    +	private final TypeSerializer<L> leftSerializer;
    +
    +	private final TypeSerializer<R> rightSerializer;
    +
    +	public EitherSerializer(Class<Either<L, R>> typeClass, TypeSerializer<L>
leftSerializer, TypeSerializer<R> rightSerializer) {
    +		this.typeClass = typeClass;
    +		this.leftSerializer = leftSerializer;
    +		this.rightSerializer = rightSerializer;
    +	}
    +
    +	@Override
    +	public boolean isImmutableType() {
    +		return true;
    +	}
    +
    +	@Override
    +	public TypeSerializer<Either<L, R>> duplicate() {
    +		TypeSerializer<L> duplicateLeft = leftSerializer.duplicate();
    +		TypeSerializer<R> duplicateRight = rightSerializer.duplicate();
    +
    +		if ((leftSerializer != duplicateLeft) || (rightSerializer != duplicateRight)) {
    +			// stateful
    +			return new EitherSerializer<L, R>(typeClass, duplicateLeft, duplicateRight);
    +		}
    +		else {
    +			return this;
    +		}
    +	}
    +
    +
    +	@Override
    +	public Either<L, R> createInstance() {
    +		// We arbitrarily always create a Left value instance.
    +		return Either.left(leftSerializer.createInstance());
    --- End diff --
    
    Assuming that the failure case occurs seldom.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message