flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2901] Remove Record API dependencies fr...
Date Tue, 17 Nov 2015 14:21:23 GMT
Github user zentol commented on the pull request:

    https://github.com/apache/flink/pull/1306#issuecomment-157382048
  
    @fhueske I've addressed most of your concerns.
    
    Things that still need work / clarification:
    * PreviewPlanDumpTest was previously executed with 2 different sets of arguments, now
only with 1. Should this be changed back to the previous behaviour? The arguments affect paths
for sources/sink, parallelism and the number of Iterations
    * test.classloading.jar.KMeansForTest appears to be a good replacement for the IterativeKMeansITCase,
what's your take on that?
    * The removed delta ilteration PageRank program looks very similar to the ConnectedComponents
implementation under flink-examples. I don't think this needs a separate port.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message