flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-7] [Runtime] Enable Range Partitioner.
Date Tue, 10 Nov 2015 14:04:23 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/shipping/OutputEmitter.java
    @@ -231,4 +268,44 @@ private int murmurHash(int k) {
     			throw new RuntimeException("Error while calling custom partitioner.", t);
    +	private final int compareRecordAndBoundary(T record, Object[] boundary) {
    +		TypeComparator[] flatComparators = this.comparator.getFlatComparators();
    --- End diff --
    can we cache the `flatComparators` and `keys` to avoid many object instantiations?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message