flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: Remove and forbid use of SerializationUtils. F...
Date Tue, 10 Nov 2015 13:20:39 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1343#discussion_r44404693
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
---
    @@ -167,15 +166,11 @@ public WindowedStream(KeyedStream<T, K> input,
     					evictor).enableSetProcessingTime(setProcessingTime);
     
     		} else {
    -			// we need to copy because we need our own instance of the pre aggregator
    -			@SuppressWarnings("unchecked")
    -			ReduceFunction<T> functionCopy = (ReduceFunction<T>) SerializationUtils.clone(function);
    --- End diff --
    
    Could you explain why the copy is not necessary here anymore?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message