flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...
Date Mon, 02 Nov 2015 11:07:31 GMT
Github user mxm commented on the pull request:

    It's fine to have separate code for detached and blocking submission where necessary.
I was more concerned with this pull request that it introduces new code branches which distort
the existing submission logic. Wherever possible we should try to be explicit about the submission
code path we're in instead of mixing them all together.
    For instance, you're setting `lastEnvĀ“ on blocking execution but then you never access
it during blocking execution. This is not a clear code style.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message