Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DD7171869E for ; Thu, 22 Oct 2015 09:54:27 +0000 (UTC) Received: (qmail 25589 invoked by uid 500); 22 Oct 2015 09:54:27 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 25540 invoked by uid 500); 22 Oct 2015 09:54:27 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 25529 invoked by uid 99); 22 Oct 2015 09:54:27 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Oct 2015 09:54:27 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A82AC2C044E for ; Thu, 22 Oct 2015 09:54:27 +0000 (UTC) Date: Thu, 22 Oct 2015 09:54:27 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-2874) Certain Avro generated getters/setters not recognized MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968883#comment-14968883 ] ASF GitHub Bot commented on FLINK-2874: --------------------------------------- Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1252#issuecomment-150165291 Looks good to me as well. Should we add this fix to 0.10 RC1 as well? > Certain Avro generated getters/setters not recognized > ----------------------------------------------------- > > Key: FLINK-2874 > URL: https://issues.apache.org/jira/browse/FLINK-2874 > Project: Flink > Issue Type: Bug > Components: Core > Affects Versions: 0.9.1, 0.9.0, 0.10 > Reporter: Ulf Karlsson > Priority: Minor > Original Estimate: 2h > Remaining Estimate: 2h > > For Avro schemas where value null is not allowed, the field is unboxed e.g. int but the getter/setter methods provide the boxed Integer as interface: > {code} > { > "fields": [ > { > "type": "double", > "name": "time" > }, > } > {code} > This results in Java > {code} > private double time; > public java.lang.Double getTime() { > return time; > } > public void setTime(java.lang.Double value) { > this.time = value; > } > {code} > There is also a problem when there is an underscore in the Avro schema, e.g.: > {code} > { > "default": null, > "type": [ > "null", > "long" > ], > "name": "conn_id" > }, > {code} > This results in Java: > {code} > private java.lang.Long conn_id; > public java.lang.Long getConnId() { > return conn_id; > } > public void setConnId(java.lang.Long value) { > this.conn_id = value; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)