Return-Path: 
 <issues-return-32206-apmail-flink-issues-archive=flink.apache.org@flink.apache.org>
X-Original-To: apmail-flink-issues-archive@minotaur.apache.org
Delivered-To: apmail-flink-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 08FC218591
	for <apmail-flink-issues-archive@minotaur.apache.org>;
 Tue,  6 Oct 2015 15:28:30 +0000 (UTC)
Received: (qmail 3688 invoked by uid 500); 6 Oct 2015 15:28:26 -0000
Delivered-To: apmail-flink-issues-archive@flink.apache.org
Received: (qmail 3642 invoked by uid 500); 6 Oct 2015 15:28:26 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 3632 invoked by uid 99); 6 Oct 2015 15:28:26 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Oct 2015 15:28:26 +0000
Date: Tue, 6 Oct 2015 15:28:26 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12851353.1438680876000.36611.1444145306839@Atlassian.JIRA>
In-Reply-To: <JIRA.12851353.1438680876000@Atlassian.JIRA>
References: <JIRA.12851353.1438680876000@Atlassian.JIRA>
 <JIRA.12851353.1438680876930@arcas>
Subject: [jira] [Commented] (FLINK-2479) Refactoring of
 org.apache.flink.runtime.operators.testutils.TestData class
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/FLINK-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945182#comment-14945182 ] 

ASF GitHub Bot commented on FLINK-2479:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1160#discussion_r41279323
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReusingHashMatchIteratorITCase.java ---
    @@ -692,24 +685,24 @@ public void join(Record rec1, Record rec2, Collector<Record> out) throws Excepti
     		}
     	}
     	
    -	static final class RecordIntPairMatchRemovingMatcher extends AbstractRichFunction implements FlatJoinFunction<IntPair, Record, Record>
    +	static final class RecordIntPairMatchRemovingMatcher extends AbstractRichFunction implements FlatJoinFunction<IntPair, Tuple2<Integer, String>, Tuple2<Integer, String>>
    --- End diff --
    
    should be TupleIntPairMatchRemovingMatcher


> Refactoring of org.apache.flink.runtime.operators.testutils.TestData class
> --------------------------------------------------------------------------
>
>                 Key: FLINK-2479
>                 URL: https://issues.apache.org/jira/browse/FLINK-2479
>             Project: Flink
>          Issue Type: Task
>          Components: Local Runtime
>            Reporter: Ricky Pogalz
>            Assignee: Chesnay Schepler
>            Priority: Minor
>             Fix For: pre-apache
>
>
> Currently, there are still tests which use {{Record}} from the old record API. One of the test util classes is {{TestData}}, including {{Generator}} and some other classes still using {{Record}}. An alternative implementation of the {{Generator}} without {{Record}} already exists in the {{TestData}} class, namely {{TupleGenerator}}.
> Please replace the utility classes in {{TestData}} that still use {{Record}} and adapt all of its usages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)