Return-Path: 
 <issues-return-34736-apmail-flink-issues-archive=flink.apache.org@flink.apache.org>
X-Original-To: apmail-flink-issues-archive@minotaur.apache.org
Delivered-To: apmail-flink-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 1A61618EB9
	for <apmail-flink-issues-archive@minotaur.apache.org>;
 Fri, 30 Oct 2015 22:07:14 +0000 (UTC)
Received: (qmail 85368 invoked by uid 500); 30 Oct 2015 22:07:14 -0000
Delivered-To: apmail-flink-issues-archive@flink.apache.org
Received: (qmail 85342 invoked by uid 500); 30 Oct 2015 22:07:13 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 85333 invoked by uid 99); 30 Oct 2015 22:07:13 -0000
Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Oct 2015 22:07:13 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org)
 with ESMTP id 8562FC14F0
	for <issues@flink.apache.org>; Fri, 30 Oct 2015 22:07:13 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.971
X-Spam-Level: 
X-Spam-Status: No, score=0.971 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01,
	RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001]
	autolearn=disabled
Received: from mx1-us-west.apache.org ([10.40.0.8])
	by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new,
 port 10024)
	with ESMTP id YqpMMCCTkf6s for <issues@flink.apache.org>;
	Fri, 30 Oct 2015 22:07:04 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with
 SMTP id EE19C212A3
	for <issues@flink.incubator.apache.org>;
 Fri, 30 Oct 2015 22:07:03 +0000 (UTC)
Received: (qmail 85240 invoked by uid 99); 30 Oct 2015 22:07:03 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Oct 2015 22:07:03 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 91085E042F; Fri, 30 Oct 2015 22:07:03 +0000 (UTC)
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-1299-flink@git.apache.org>
In-Reply-To: <git-pr-1299-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-2918] Add method to read a file
 of type...
Content-Type: text/plain
Message-Id: <20151030220703.91085E042F@git1-us-west.apache.org>
Date: Fri, 30 Oct 2015 22:07:03 +0000 (UTC)

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1299#discussion_r43557662
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java ---
    @@ -580,6 +580,14 @@ public CsvReader readCsvFile(String filePath) {
     	}
     
     	/**
    +	 * Creates a {@link DataSet} from {@link org.apache.hadoop.mapred.SequenceFileInputFormat}
    +	 * A {@link org.apache.hadoop.mapred.JobConf} with the given inputPath is created.
    + 	 */
    +	public <K,V> DataSource<Tuple2<K, V>> readAsSequenceFile(Class<K> key, Class<V> value, String inputPath) throws IOException {
    --- End diff --
    
    Can we rename the method to `readSequenceFile()` to have it consistent with the other methods (`readCsvFile`, `readHadoopFile`, ...)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---