Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: tillrohrmann <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-1202-flink@git.apache.org>
In-Reply-To: <git-pr-1202-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-2793] [dashboard] Redirect to
 leader in...
Content-Type: text/plain
Message-Id: <20151006143739.3ADC4DFB87@git1-us-west.apache.org>
Date: Tue,  6 Oct 2015 14:37:39 +0000 (UTC)

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1202#discussion_r41272107
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/JobManagerArchiveRetriever.java ---
    @@ -47,51 +60,160 @@
     	private final FiniteDuration timeout;
     	private final WebMonitor webMonitor;
     
    +	/** Pattern to extract the host from an remote Akka URL */
    +	private final Pattern hostFromLeaderAddressPattern = Pattern.compile("^.+@(.+):([0-9]+)/user/.+$");
    +
    +	/** The JobManager Akka URL associated with this JobManager */
    +	private volatile String jobManagerAkkaUrl;
    +
     	/** will be written and read concurrently */
     	private volatile ActorGateway jobManagerGateway;
     	private volatile ActorGateway archiveGateway;
    +	private volatile String redirectWebMonitorAddress;
     
     	public JobManagerArchiveRetriever(
     			WebMonitor webMonitor,
     			ActorSystem actorSystem,
     			FiniteDuration lookupTimeout,
     			FiniteDuration timeout) {
    -		this.webMonitor = webMonitor;
    -		this.actorSystem = actorSystem;
    -		this.lookupTimeout = lookupTimeout;
    -		this.timeout = timeout;
    +
    +		this.webMonitor = checkNotNull(webMonitor);
    +		this.actorSystem = checkNotNull(actorSystem);
    +		this.lookupTimeout = checkNotNull(lookupTimeout);
    +		this.timeout = checkNotNull(timeout);
    +	}
    +
    +	/**
    +	 * Associates this instance with the job manager identified by the given URL.
    +	 *
    +	 * <p>This has to match the URL retrieved by the leader retrieval service. In tests setups you
    +	 * have to make sure to use the correct type of URLs.
    +	 */
    +	public void setJobManagerAkkaUrlAndRetrieveGateway(String jobManagerAkkaUrl) throws Exception {
    --- End diff --
    
    Actually, I meant to get rid of this extra redirect logic here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---