Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C0DAF1818F for ; Sun, 4 Oct 2015 20:06:41 +0000 (UTC) Received: (qmail 61976 invoked by uid 500); 4 Oct 2015 20:06:41 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 61934 invoked by uid 500); 4 Oct 2015 20:06:41 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 61925 invoked by uid 99); 4 Oct 2015 20:06:41 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 04 Oct 2015 20:06:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 11778C0479 for ; Sun, 4 Oct 2015 20:06:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.025 X-Spam-Level: X-Spam-Status: No, score=-0.025 tagged_above=-999 required=6.31 tests=[RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.006, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id VXku4wnFH3-Y for ; Sun, 4 Oct 2015 20:06:32 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id E8DDC20F4A for ; Sun, 4 Oct 2015 20:06:31 +0000 (UTC) Received: (qmail 61807 invoked by uid 99); 4 Oct 2015 20:06:31 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 04 Oct 2015 20:06:31 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6F12DDFC77; Sun, 4 Oct 2015 20:06:31 +0000 (UTC) From: chiwanpark To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request: [FLINK-2815] [REFACTOR] Remove Pact from class... Content-Type: text/plain Message-Id: <20151004200631.6F12DDFC77@git1-us-west.apache.org> Date: Sun, 4 Oct 2015 20:06:31 +0000 (UTC) Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1218#discussion_r41101714 --- Diff: flink-staging/flink-tez/src/main/java/org/apache/flink/tez/runtime/TezTask.java --- @@ -402,7 +402,7 @@ private void initInputLocalStrategy(int inputNum) throws Exception { localStub = initStub(userCodeFunctionType); } catch (Exception e) { throw new RuntimeException("Initializing the user code and the configuration failed" + - e.getMessage() == null ? "." : ": " + e.getMessage(), e); + (e.getMessage() == null ? "." : ": ") + e.getMessage(), e); --- End diff -- It seems wrong parenthesis. If `e.getMessage()` is `null`, there is concatenation of `"."` and `null`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---