flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2874) Certain Avro generated getters/setters not recognized
Date Thu, 22 Oct 2015 09:54:27 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968883#comment-14968883
] 

ASF GitHub Bot commented on FLINK-2874:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1252#issuecomment-150165291
  
    Looks good to me as well. Should we add this fix to 0.10 RC1 as well?


> Certain Avro generated getters/setters not recognized
> -----------------------------------------------------
>
>                 Key: FLINK-2874
>                 URL: https://issues.apache.org/jira/browse/FLINK-2874
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.9.1, 0.9.0, 0.10
>            Reporter: Ulf Karlsson
>            Priority: Minor
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> For Avro schemas where value null is not allowed, the field is unboxed e.g. int but the
getter/setter methods provide the boxed Integer as interface:
> {code}
> {
>  "fields": [
>   {
>    "type": "double", 
>    "name": "time"
>   }, 
> }
> {code}
> This results in Java
> {code}
>   private double time;
>   public java.lang.Double getTime() {
>     return time;
>   }
>   public void setTime(java.lang.Double value) {
>     this.time = value;
>   }
> {code}
> There is also a problem when there is an underscore in the Avro schema, e.g.:
> {code}
>   {
>    "default": null, 
>    "type": [
>     "null", 
>     "long"
>    ], 
>    "name": "conn_id"
>   }, 
> {code}
> This results in Java:
> {code}
> private java.lang.Long conn_id;
>   public java.lang.Long getConnId() {
>     return conn_id;
>   }
>   public void setConnId(java.lang.Long value) {
>     this.conn_id = value;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message