flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2810) Warn user if bc not installed
Date Mon, 05 Oct 2015 17:04:26 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943661#comment-14943661
] 

ASF GitHub Bot commented on FLINK-2810:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1228#discussion_r41169165
  
    --- Diff: flink-dist/src/main/flink-bin/bin/taskmanager.sh ---
    @@ -73,6 +73,13 @@ if [[ $STARTSTOP == "start" ]]; then
                     TM_OFFHEAP_SIZE=${FLINK_TM_MEM_MANAGED_SIZE}
                     TM_HEAP_SIZE=$((FLINK_TM_HEAP - FLINK_TM_MEM_MANAGED_SIZE))
                 else
    +                # Bash only performs integer arithmetic so floating point computation
is performed using bc
    +                BC_PATH=`command -v bc`
    +                if [[ $? -eq 1 || ! -f $BC_PATH ]]; then
    --- End diff --
    
    I think this may cause problems when `bc` is symlinked. The error code of `command -v
bc` should be enough.


> Warn user if bc not installed
> -----------------------------
>
>                 Key: FLINK-2810
>                 URL: https://issues.apache.org/jira/browse/FLINK-2810
>             Project: Flink
>          Issue Type: Improvement
>          Components: Command-line client
>    Affects Versions: 0.10
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>             Fix For: 0.10
>
>
> taskmanager.sh will print the following message when starting the cluster if bc is not
installed and off-heap memory is enabled and configured as a ratio. The script should first
check that bc is installed and otherwise print a specific message.
> {noformat}
> [ERROR] Configured TaskManager managed memory fraction is not a valid value. Please set
'taskmanager.memory.fraction' in flink-conf.yaml
> {noformat}
> An example of a distribution where bc is not installed by default are the Debian images
for Google Compute Engine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message