flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2479) Refactoring of org.apache.flink.runtime.operators.testutils.TestData class
Date Tue, 06 Oct 2015 15:28:26 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945182#comment-14945182
] 

ASF GitHub Bot commented on FLINK-2479:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1160#discussion_r41279323
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/ReusingHashMatchIteratorITCase.java
---
    @@ -692,24 +685,24 @@ public void join(Record rec1, Record rec2, Collector<Record>
out) throws Excepti
     		}
     	}
     	
    -	static final class RecordIntPairMatchRemovingMatcher extends AbstractRichFunction implements
FlatJoinFunction<IntPair, Record, Record>
    +	static final class RecordIntPairMatchRemovingMatcher extends AbstractRichFunction implements
FlatJoinFunction<IntPair, Tuple2<Integer, String>, Tuple2<Integer, String>>
    --- End diff --
    
    should be TupleIntPairMatchRemovingMatcher


> Refactoring of org.apache.flink.runtime.operators.testutils.TestData class
> --------------------------------------------------------------------------
>
>                 Key: FLINK-2479
>                 URL: https://issues.apache.org/jira/browse/FLINK-2479
>             Project: Flink
>          Issue Type: Task
>          Components: Local Runtime
>            Reporter: Ricky Pogalz
>            Assignee: Chesnay Schepler
>            Priority: Minor
>             Fix For: pre-apache
>
>
> Currently, there are still tests which use {{Record}} from the old record API. One of
the test util classes is {{TestData}}, including {{Generator}} and some other classes still
using {{Record}}. An alternative implementation of the {{Generator}} without {{Record}} already
exists in the {{TestData}} class, namely {{TupleGenerator}}.
> Please replace the utility classes in {{TestData}} that still use {{Record}} and adapt
all of its usages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message