flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2897] [runtime] Use distinct initial in...
Date Fri, 23 Oct 2015 10:03:54 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1292#discussion_r42849790
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/shipping/OutputEmitter.java
---
    @@ -143,14 +148,25 @@ public OutputEmitter(ShipStrategyType strategy, TypeComparator<T>
comparator, Pa
     	
     	// --------------------------------------------------------------------------------------------
     
    +	private int[] forward() {
    +		if (this.channels == null) {
    --- End diff --
    
    This method preserves the behavior of `FORWARD` only if `numberOfChannels` is always 0
when `FORWARD` is configured which is out of control of the `OutputEmitter`.
    Should we add a check somewhere (e.g., in this condition to reduce the overhead) to ensure
that `numberOfChannels` is acutally 0 for `FORWARD`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message