flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sachingoel0101 <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2797][cli] Add support for running jobs...
Date Thu, 22 Oct 2015 16:52:10 GMT
Github user sachingoel0101 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1214#discussion_r42774255
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
    @@ -277,12 +278,20 @@ else if (prog.isUsingInteractiveMode()) {
     			// invoke here
     			try {
     				prog.invokeInteractiveModeForExecution();
    +				// if we're here, it means the program is valid for detached mode execution.
    +				JobWithJars plan = ContextEnvironment.ContextEnvironmentFactory.getPlan();
    +				JobGraph graph = ContextEnvironment.ContextEnvironmentFactory.getGraph();
    +				if (plan != null && graph == null) {
    --- End diff --
    
    Ah. I had not considered this possibility. What should be done in such a case? Execute
both programs? That does make sense, but what should be the return value? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message