flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2017] Add predefined required parameter...
Date Wed, 21 Oct 2015 16:59:14 GMT
Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1097#issuecomment-149961803
  
    Looks like good progress! As pointed out in one of my comments, I think we should make
the use a bit more intuitive. Having two methods which are named so similar but which do different
things is not a good idea. IMO it would be better to have one method that applies (and checks)
the required options to the parsed parameters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message