flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sachingoel0101 <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2731][web-dashboard] Adds access to Job...
Date Sun, 18 Oct 2015 18:25:16 GMT
Github user sachingoel0101 commented on the pull request:

    https://github.com/apache/flink/pull/1233#issuecomment-149036747
  
    @mxm I've rebased on your latest changes to enable dashboard on yarn. 
    Also, there was a little redundant code in `StaticFileServerHandler` 
    ```java
    if (File.separatorChar != '/') {
        requestPath = requestPath.replace('/', File.separatorChar);
    }
    ```
    which I think was meant to make sure things work on windows, but it doesn't actually serve
that purpose. I've removed it in the second commit.
    
    The log and out files are now accessible both with and without yarn. I have also enabled
the logs related tests on both `YARNSessionFIFOITCase` and `WebFrontendITCase`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message