flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mbalassi <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2779][FLINK-2794][streaming][docs] New ...
Date Thu, 08 Oct 2015 13:18:31 GMT
Github user mbalassi commented on the pull request:

    https://github.com/apache/flink/pull/1208#issuecomment-146542207
  
    Thanks for this big update, guys!
    
    Some comments:
      * Explanation of operator chaining and options are missing.
      * Collection Data Sources: The following sentence should be removed: 'Currently, the
collection data source requires that data types and iterators implement Serializable.' This
is not true anymore.
      * Transformations DataStream,DataStream → DataStream looks better with a tuple-style
input for me: (DataStream, DataStream) → DataStream if that fits on the page.
      * In the source code examples I would use the diamond operator for Java7, e.g. in the
Splitter of the WC.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message