flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2779][FLINK-2794][streaming][docs] New ...
Date Thu, 08 Oct 2015 09:03:04 GMT
Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1208#issuecomment-146464070
  
    Last part of review:
    
    Connectors
    - (with the exception of Twitter where only a source is provided and Elasticsearch where
only a sink is provided) -> The following list only shows sink for HDFS. I'd just remove
the exception sentence.
    
    Kafka Source:
    - This section describes the FlinkKafkaConsumer082 and not the KafkaSource
    
    Kafka Sink: 
    - This sentence is confusing, IMO: "Also the serializer configuration should be left default,
the serialization should be set via SerializationSchema."
    
    Elasticsearch:
    - "Sink" is sometimes capitalized, sometimes not.
    - Not how -> Note how
    
    Hadoop FileSystem
    - Hadoop FileSystem -> Hadoop File System
    - "Sink" is sometimes capitalized, sometimes not.
    
    Twitter Streaming API
    - Remember to keep these pieces of information a secret -> Remember to keep these pieces
of information secret (remove "a")
    - numberOfTweets determine how many tweet the source emits. -> numberOfTweets determineS
how many tweet the source emits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message