flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iampeter <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2730][web-dashboard] Adds cpu and memor...
Date Wed, 07 Oct 2015 21:23:29 GMT
Github user iampeter commented on the pull request:

    @sachingoel0101 @aljoscha looks great, but I would make the following changes if possible:
    1. Move the 'livechart' directive to a separate file - `taskmanager.dir.coffee`
    2. Move the Highcharts config in `index.coffee` to either `.run()` in `index.coffee`,
or the directive
    3. Remove the 'No such task manager exits' text that blinks when the task manager details
are loading

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message