flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2793] [dashboard] Redirect to leader in...
Date Tue, 06 Oct 2015 14:39:56 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
    @@ -150,97 +148,97 @@ else if (flinkRoot != null) {
     		FiniteDuration lookupTimeout = AkkaUtils.getTimeout(config);
     		retriever = new JobManagerArchiveRetriever(this, actorSystem, lookupTimeout, timeout);
     		ExecutionGraphHolder currentGraphs = new ExecutionGraphHolder(retriever);
     		router = new Router()
     			// config how to interact with this web server
    -			.GET("/config", handler(new DashboardConfigHandler(cfg.getRefreshInterval())))
    +			.GET("/config", handler(new DashboardConfigHandler(cfg.getRefreshInterval()), retriever))
     			// the overview - how many task managers, slots, free slots, ...
    -			.GET("/overview", handler(new ClusterOverviewHandler(retriever, DEFAULT_REQUEST_TIMEOUT)))
    +			.GET("/overview", handler(new ClusterOverviewHandler(retriever, DEFAULT_REQUEST_TIMEOUT),
     			// job manager configuration
    -			.GET("/jobmanager/config", handler(new JobManagerConfigHandler(config)))
    +			.GET("/jobmanager/config", handler(new JobManagerConfigHandler(config), retriever))
     			// overview over jobs
    -			.GET("/joboverview", handler(new CurrentJobsOverviewHandler(retriever, DEFAULT_REQUEST_TIMEOUT,
true, true)))
    -			.GET("/joboverview/running", handler(new CurrentJobsOverviewHandler(retriever, DEFAULT_REQUEST_TIMEOUT,
true, false)))
    -			.GET("/joboverview/completed", handler(new CurrentJobsOverviewHandler(retriever, DEFAULT_REQUEST_TIMEOUT,
false, true)))
    +			.GET("/joboverview", handler(new CurrentJobsOverviewHandler(retriever, DEFAULT_REQUEST_TIMEOUT,
true, true), retriever))
    --- End diff --
    Start the `RequestHandler` with the JobManager address of the local JobManager. They will
only be called from the `RuntimeMonitorHandler` if the local JM is the leader.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message