flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2805] [blobmanager] Write JARs to file ...
Date Tue, 06 Oct 2015 09:27:33 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1227#discussion_r41243069
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
    @@ -102,8 +161,13 @@ public BlobServer(Configuration config) throws IOException {
     			backlog = ConfigConstants.DEFAULT_BLOB_FETCH_BACKLOG;
     		}
     
    -		// Add shutdown hook to delete storage directory
    -		this.shutdownHook = BlobUtils.addShutdownHook(this, LOG);
    +		if (recoveryMode == RecoveryMode.STANDALONE) {
    --- End diff --
    
    I assume that `==` is correct, but then the JavaDoc is wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message