flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2354] Add job graph and checkpoint reco...
Date Mon, 05 Oct 2015 14:49:51 GMT
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1153#issuecomment-145554976
  
    Great piece of work @uce :-) I've gone through the code and added some comments. The main
points are 
    
     * the exception handling in `ZooKeeperSubmittedJobGraphs` which can fail the job submission
if two JMs try to write `JobGraphs` with the same `JobID`
     * and the usage of a shared counter which could maybe replaced by creating the `SuccessfulCheckpoint`
nodes in `PERSISTENT_SEQUENTIAL` mode


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message